nixos/acme: Fix postRun in acme certificate being ran at every run #85366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
arianvp
reviewed
Apr 16, 2020
| @@ -336,7 +338,10 @@ in | |||
| chmod ${fileMode} *.pem | |||
| chown '${data.user}:${data.group}' *.pem | |||
|
|
|||
| ${data.postRun} | |||
| if [ "$KEY_CHANGED" = "yes" ]; then | |||
| : # noop in case postRun is empty | |||
There was a problem hiding this comment.
is this : a typo or is this a bash-ism i dont know?
There was a problem hiding this comment.
It’s a bash-ism you don’t know :)
It’s noop
There was a problem hiding this comment.
I may replace it with a better-known true if you’re more comfortable
|
@GrahamcOfBorg test acme |
arianvp
approved these changes
Apr 17, 2020
|
The commit message doesn't match contribution guidelines. Should be like |
10 tasks
immae
force-pushed
the
fix_acme_postrun_20_03
branch
from
fae2bd6
to
e551bde
Compare
Updated @worldofpeace |
|
@immae I think you forgot to use |
(cherry picked from commit 8e88b8d)
immae
force-pushed
the
fix_acme_postrun_20_03
branch
from
e551bde
to
ed20edf
Compare
No, it’s just not in my practices. I fixed that |
worldofpeace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Backport of #85365 to 20.03
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)