Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.18.0 -> 1.18.1 #85354

Merged
merged 1 commit into from Apr 17, 2020
Merged

kubernetes: 1.18.0 -> 1.18.1 #85354

merged 1 commit into from Apr 17, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Apr 16, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker April 16, 2020 06:05
@CloudArtAdmins
Copy link
Contributor

I am not sure how to judge if bins work.
They don't all have help options, but it builds.
This builds for me.

saschagrunert
saschagrunert approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

johanot
johanot approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@johanot johanot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a couple of attempts (happy test race conditions), the tests passed on my machine :)

$ nix-build -I nixpkgs=. nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode

/nix/store/irjyjsm6kmf8js31xwwnh1gyizkvh7pv-vm-test-run-kubernetes-rbac-singlenode
/nix/store/a3fdj1bf38mxmah1m7kmnnyrdw0ikzk6-vm-test-run-kubernetes-rbac-multinode
/nix/store/vq25yc76n4w15w13xfzm06z560k25nlz-vm-test-run-kubernetes-dns-singlenode
/nix/store/3f9dk0nkwd5gyl08v12vj0gickp0rixr-vm-test-run-kubernetes-dns-multinode

LGTM too. Thanks!

@johanot
Copy link
Contributor

johanot commented Apr 17, 2020

1.18.2 just arrived :)

@srhb
Copy link
Contributor Author

srhb commented Apr 17, 2020

I'll PR that later. 😸

@srhb srhb merged commit 1d20b28 into NixOS:master Apr 17, 2020
@srhb srhb deleted the k8s-1.18.1 branch April 17, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@johanot johanot johanot approved these changes

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @CloudArtAdmins @johanot @saschagrunert