-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
bazel_latest: 2.1.0 -> 3.0.0 #85356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel_latest: 2.1.0 -> 3.0.0 #85356
Conversation
Not sure what this is about, is it a preexisting issue on master?
|
This removes Bazel 2, which I don't think is what we want. I think a separate commit introducing Bazel 3 ( |
correct, please leave the individual bazel version, then bazel_latest should just be aliased to whatever happens to be latest |
don't want to end up with tensorflow broken for another 4 months |
Tensorflow uses That way we don't add more and more bazel derivations with no clear way of reducing the number of them. |
Bazel releases a new major at most every 3 months, according to: Bazel 1.0.0: 2019-10-10 https://github.com/bazelbuild/bazel/releases/tag/1.0.0 This is why I think there's too many version to keep them all regardless of whether another derivation is using them or not. |
I can definitely see the use case where a future version of tensorflow requires bazel_2. |
One possible policy would be to always keep
Keeping the last major release will make it possible to use a semi-recent version of bazel in packages like tensorflow which always lag behind a bit. |
Tensorflow 2.1.0 (latest stable release) requires bazel 0.29; they're currently doing the release candidates for 2.2.0, which looks like it's going to be on bazel 3.0: So it might be OK to drop bazel 2.0. |
Rebased on current master to see if the issue is still there. ping @mboes @kalbasit @Profpatsch |
I'm still getting the same error, but I haven't figured out how to reproduce it locally. |
We can revive bazel versions posthumously if some package upgrades to an older version. |
Agreed, I'd say delete old bazel versions, unless it's actually being used by something that can't upgrade to a newer one. |
Huh @uri-canva, what’s the reason this PR was closed? |
I never managed to figure out the reason behind this error on ofborg:
I switched to using bazelisk from nix and instead of bazel, and letting bazelisk get bazel, so I closed this PR so other people wouldn't get blocked on it and could start their own attempts to upgrade. |
FYI Tensorflow 2.2 build with bazel 2.0.0 |
Motivation for this change
Upgrade to latest version of Bazel.
Things done
Renamed
bazel_2
tobazel_latest
, upgraded.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)