Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnupg: use libusb1 #85374

Merged
merged 2 commits into from Apr 21, 2020
Merged

gnupg: use libusb1 #85374

merged 2 commits into from Apr 21, 2020

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Apr 16, 2020 •
edited

Motivation for this change

This fixes scdaemon's direct ccid support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lheckemann
gnupg: use libusb1
a82188d 
This fixes scdaemon's direct ccid support.
@lheckemann
systemd: fix gnupg-minimal
44f533d
@ofborg ofborg bot requested review from fpletz, peti and vrthra April 16, 2020 15:16
@lheckemann lheckemann changed the base branch from master to staging April 16, 2020 18:53
@FRidh FRidh added this to WIP in Staging via automation Apr 21, 2020
@FRidh FRidh merged commit 6673a49 into NixOS:staging Apr 21, 2020
Staging automation moved this from WIP to Done Apr 21, 2020
@lheckemann lheckemann deleted the gpg-scdaemon-fix branch April 21, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@peti peti Awaiting requested review from peti

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @FRidh