colobot: init at 0.1.12-alpha #85419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Apr 17, 2020
colobot: remove vorbisTools argument colobot: reduce scope of `colobotMusic` colobot: use cmake flag instead of using sed colobot: clean up regex
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
merge commits adding you to maintainers into a single commit with a message "maintainers: add wesnel", and other commits for adding colobot package into single commit with a commit message "colobot: init at 0.1.12" |
stale
bot
removed
the
2.status: stale
Comment on lines
+176
to
+177
|
|
||
| colobot = callPackage ../games/colobot { }; |
There was a problem hiding this comment.
Suggested change
| colobot = callPackage ../games/colobot { }; | |
| colobot = callPackage ../games/colobot { }; |
| tar -xvf ${colobotMusic} -Cdata/music | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
stdenv.lib is deprecated.
Comment on lines
+76
to
+77
| sed -i 's/find_program(WGET wget)//' \ | ||
| data/music/CMakeLists.txt |
There was a problem hiding this comment.
Please use substituteInPlace.
Comment on lines
+67
to
+68
| url = | ||
| "https://colobot.info/files/music/colobot-music_ogg_${version}.tar.gz"; |
There was a problem hiding this comment.
Suggested change
| url = | |
| "https://colobot.info/files/music/colobot-music_ogg_${version}.tar.gz"; | |
| url = "https://colobot.info/files/music/colobot-music_ogg_${version}.tar.gz"; |
| cmakeFlags = [ "-DCOLOBOT_INSTALL_BIN_DIR=${placeholder "out"}/bin" ]; | ||
|
|
||
| postPatch = let | ||
| colobotMusic = fetchurl { |
There was a problem hiding this comment.
Please move that into a let in before mkDerivation.
There was a problem hiding this comment.
IMHO using narrower scopes is better.
| gettext | ||
| librsvg | ||
| perl | ||
| python27 |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
PR #103077 added the same package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've added a derivation for Colobot, a GPL-licensed educational programming game. Thanks for looking!
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)