upwork: init at 5.3.3-883 #85396
upwork: init at 5.3.3-883 #85396
Conversation
| , pango, systemd, libXScrnSaver, libcxx, libpulseaudio }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "upwork-${version}"; |
There was a problem hiding this comment.
| name = "upwork-${version}"; | |
| pname = "upwork"; |
| nativeBuildInputs = [ | ||
| dpkg | ||
| wrapGAppsHook | ||
| autoPatchelfHook |
There was a problem hiding this comment.
not really sure this is needed since you're creating a LD_LIBRARY_PATH for the program wrapper
| autoPatchelfHook |
There was a problem hiding this comment.
As far as I can tell it doesn't work without doing patchelf
| version = "5.3.3-883"; | ||
|
|
||
| src = fetchurl { | ||
| url = https://updates-desktopapp.upwork.com/binaries/v5_3_3_883_1f817bc1fefd44e7/upwork_5.3.3.883_amd64.deb; |
There was a problem hiding this comment.
Wrap the url in quotes (as per RFC45)
|
Running Running In a pure shell however, the symlink gives the same "No protocol specified" error. Tested with |
thats because there's not a it's unfortunate, but just a lot of GUI applications need some impurity to work |
|
I've implemented all your suggestions and used |
There was a problem hiding this comment.
diff LGTM
gui launches fine
[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/85396
43 package marked as broken and skipped:
clang-sierraHack-stdenv crossLibcStdenv digitalbitbox glibcCross iterm2 linuxPackages-libre.sch_cake linuxPackages.sch_cake linuxPackages_4_14.sch_cake linuxPackages_4_19.sch_cake linuxPackages_4_4.evdi linuxPackages_4_4.sysdig linuxPackages_4_9.sysdig linuxPackages_5_5.sch_cake linuxPackages_5_6.sch_cake linuxPackages_hardened.sch_cake linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.rtl8814au linuxPackages_hardkernel_4_14.rtl8821ce linuxPackages_hardkernel_4_14.rtlwifi_new linuxPackages_hardkernel_4_14.sch_cake linuxPackages_hardkernel_4_14.v4l2loopback linuxPackages_latest-libre.sch_cake linuxPackages_xen_dom0_hardened.sch_cake muslCross newlibCross octave-jit octoprint php73Extensions.zmq php74Extensions.couchbase php74Extensions.pcs php74Extensions.pthreads python27Packages.caffe python27Packages.libmodulemd python38Packages.nixpart synfigstudio ucommon
1 package built:
upwork
|
@zakkor congrats on your first PR :) |
Motivation for this change
I needed to use the Upwork time tracker, and a package for it didn't exist.
Related issue: #30654
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)