Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

g933-utils: init at unstable-2019-08-04 #85398

Merged
merged 1 commit into from Jul 21, 2020
Merged

g933-utils: init at unstable-2019-08-04 #85398

merged 1 commit into from Jul 21, 2020

Conversation

seqizz
Copy link
Contributor

@seqizz seqizz commented Apr 16, 2020 •
edited

Motivation for this change

A tool written via Rust, helps getting/setting configuration and info from Logitech headsets.

Although some questions are present, since this is my first rust app packaging (sorry & thanks):

  • There are no release numbers upstream, I just used 0.13 as README has 13 versions. I know it's bad but what do we do in these cases?
  • Repository has some simple udev rules, including them sounds shaky since it sets a "logitech" group. Adding logitech-udev-rules package as a dependency could be enough or is this even needed?
  • Is the selected category correct?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 17, 2020

@ofborg eval

GitHub and broken APIs, name a better duo. (Sorry about this.)

dali99
dali99 suggested changes Jul 16, 2020
View reviewed changes
Copy link
Member

@dali99 dali99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for your package! Just a few changes 😸

pkgs/os-specific/linux/g933-utils/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@seqizz seqizz changed the title g933-utils: init at 0.13 g933-utils-unstable: init at 2019-08-04 Jul 18, 2020
@seqizz
Copy link
Contributor Author

seqizz commented Jul 18, 2020

Thanks for the review, I've pushed the updated branch & changed the PR name 👍

@seqizz seqizz force-pushed the g_g933utils branch 2 times, most recently from cc0e32d to 680cd67 Compare July 18, 2020 13:35
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/187

@Lassulus
Copy link
Member

hi, sadly I got this during reviewing:

hash mismatch in fixed-output derivation '/nix/store/d1fppqafi2c19jgib2ijn61dmp189hgp-g933-utils-unstable-2019-08-04-vendor.tar.gz':
  wanted: sha256:00ccvv5zv6y017f6ckg1ayc2spqxcp5ygkldz65g2ihbxcnn633v
  got:    sha256:16xgk4rc36d6lylh2dzv63ryq9s7fli3h2qva1m1p6f0gpasnk7w
cannot build derivation '/nix/store/jmksn7absc9030w8r41zl7fxiwigzlms-g933-utils-unstable-2019-08-04.drv': 1 dependencies couldn't be built

@seqizz
Copy link
Contributor Author

seqizz commented Jul 20, 2020

hi, sadly I got this during reviewing:

hash mismatch in fixed-output derivation '/nix/store/d1fppqafi2c19jgib2ijn61dmp189hgp-g933-utils-unstable-2019-08-04-vendor.tar.gz':
  wanted: sha256:00ccvv5zv6y017f6ckg1ayc2spqxcp5ygkldz65g2ihbxcnn633v
  got:    sha256:16xgk4rc36d6lylh2dzv63ryq9s7fli3h2qva1m1p6f0gpasnk7w
cannot build derivation '/nix/store/jmksn7absc9030w8r41zl7fxiwigzlms-g933-utils-unstable-2019-08-04.drv': 1 dependencies couldn't be built

Hmm I've successfully built the branch but rebased on 20.03 (and already changed to the value which it requested in the meantime.
I still don't understand what is this magical hash 😕 Anyway, changed the value again and pushed, could you re-try?

@Lassulus
Copy link
Member

looks better,
that magic hash is the hash of the cargo crates which are needed to build this project. The alternative would be to package all the dependencies for this project separately. cargoSha256 is therefore the hash of all dependencies.
Sadly the hash is somehow impure which means it changes quite often and is locally cached by the users then so they never realize it, when it gets invalidated.

@seqizz seqizz changed the title g933-utils-unstable: init at 2019-08-04 g933-utils: init at unstable-2019-08-04 Jul 21, 2020
@Lassulus Lassulus merged commit 49c6ce1 into NixOS:master Jul 21, 2020
@seqizz seqizz deleted the g_g933utils branch July 21, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@dali99 dali99 dali99 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@seqizz @cole-h @nixos-discourse @Lassulus @dali99 @grahamc