Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eclipse-scala-sdk: 4.4.1 -> 4.7.0 #85397

Closed
wants to merge 1 commit into from

Conversation

esclear
Copy link
Contributor

@esclear esclear commented Apr 16, 2020

Motivation for this change

Even though it's old, Scala IDE 4.7.0 is newer than the version 4.4.1, which is currently available in nixpkgs, but broken.

This commit fixes the break and updates Scala IDE to its most recent version.

Things done

Unfortunately scala-ide is based on eclipse 4.7 (oxygen).
Thus is requires a java SDK 8 and GTK2.

The java SDK is easily overwritten. It would have been possible to have an override gtk3 = gtk2; as well, but I opted for the

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Unfortunately scala-ide is based on eclipse 4.7 (oxygen).
Thus is requires a java SDK 8 and GTK2.
@rycee
Copy link
Member

rycee commented Apr 16, 2020

Thanks! Rebased to master in 2355d9d.

@rycee rycee closed this Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants