Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow-bin_2: fix tensorboard dependency #85399

Merged
merged 2 commits into from May 5, 2020
Merged

tensorflow-bin_2: fix tensorboard dependency #85399

merged 2 commits into from May 5, 2020

Conversation

cgevans
Copy link
Contributor

@cgevans cgevans commented Apr 16, 2020 •
edited

Motivation for this change

Fixes #85090. Tensorboard-bin_2 had the wrong tensorboard as an input, and did not include handling of the tensorboard pip hack (#44381).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 17, 2020

@ofborg eval

GitHub and broken APIs, name a better duo. (Sorry about this.)

@ofborg ofborg bot requested review from abbradar and cdepillabout April 17, 2020 01:25
cdepillabout
cdepillabout approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested this by checking out this PR and running the following:

$ nix-shell -I nixpkgs=./. -p 'python3.withPackages (p: with p; [tensorflow-bin_2])'
...
$ tensorboard  --logdir mylogdir   # this was run in the nix-shell

tensorboard appears to run fine.

I had noticed the collision of the tensorboard binaries before, so I think this fixes it.

@FRidh FRidh requested a review from Ericson2314 April 17, 2020 07:31
@bhipple bhipple merged commit 36ee1e7 into NixOS:master May 5, 2020
@mjlbach mjlbach mentioned this pull request May 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@abbradar abbradar Awaiting requested review from abbradar

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't install python with nixpkgs.python37Packages.tensorflow-bin_2
5 participants
@cgevans @cole-h @cdepillabout @grahamc @bhipple