Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.28.0 → 2.28.1 #85378

Merged
merged 1 commit into from Apr 19, 2020
Merged

webkitgtk: 2.28.0 → 2.28.1 #85378

merged 1 commit into from Apr 19, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 16, 2020

Motivation for this change

Fixes a CVE https://webkitgtk.org/security/WSA-2020-0004.html
https://webkitgtk.org/2020/04/13/webkitgtk2.28.1-released.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added 6.topic: GNOME GNOME desktop environment and its underlying platform 1.severity: security labels Apr 16, 2020
@jtojnar jtojnar requested a review from hedning April 16, 2020 15:12
@hedning
Copy link
Contributor

hedning commented Apr 16, 2020

We should really check if we can backport webkitgtk.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 and removed 6.topic: GNOME GNOME desktop environment and its underlying platform labels Apr 16, 2020
@hedning hedning merged commit 6cbf2e1 into NixOS:master Apr 19, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Apr 28, 2020
@jtojnar @dtzWill
webkitgtk: 2.28.0 → 2.28.1 (NixOS#85378)
ec958c7 
Fixes a CVE https://webkitgtk.org/security/WSA-2020-0004.html
https://webkitgtk.org/2020/04/13/webkitgtk2.28.1-released.html

(cherry picked from commit 6cbf2e1)
equirosa pushed a commit to equirosa/nixpkgs that referenced this pull request May 21, 2020
@jtojnar @equirosa
webkitgtk: 2.28.0 → 2.28.1 (NixOS#85378)
519c5f8 
Fixes a CVE https://webkitgtk.org/security/WSA-2020-0004.html
https://webkitgtk.org/2020/04/13/webkitgtk2.28.1-released.html

(cherry picked from commit 6cbf2e1)
matthewbauer pushed a commit to matthewbauer/nixpkgs that referenced this pull request May 21, 2020
@jtojnar @matthewbauer
webkitgtk: 2.28.0 → 2.28.1 (NixOS#85378)
647fc4f 
Fixes a CVE https://webkitgtk.org/security/WSA-2020-0004.html
https://webkitgtk.org/2020/04/13/webkitgtk2.28.1-released.html
@worldofpeace worldofpeace deleted the webkitgtk-2.28.1 branch August 14, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning hedning approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtojnar @hedning