Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.angstrom: 0.12.1 -> 0.13.0 #85208

Merged
merged 1 commit into from Apr 28, 2020
Merged

ocamlPackages.angstrom: 0.12.1 -> 0.13.0 #85208

merged 1 commit into from Apr 28, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Apr 14, 2020 •
edited

Motivation for this change

Update:

  • ocamlPackages.angstrom
  • ocamlPackages.angstrom-unix
  • ocamlPackages.angstrom-lwt-unix
  • ocamlPackages.angstrom-async
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.angstrom ocamlPackages.angstrom-unix ocamlPackages.angstrom-lwt-unix ocamlPackages.angstrom-async

@sternenseemann sternenseemann marked this pull request as draft April 24, 2020 14:03
@sternenseemann sternenseemann marked this pull request as ready for review April 24, 2020 15:26
@sternenseemann
Copy link
Member Author

irmin packages build with this version of angstrom (tested using nixpkgs-review).

@sternenseemann
ocamlPackages.angstrom*: 0.12.1 -> 0.13.0
1bdce50 
also updates:

* ocamlPackages.angstrom-unix
* ocamlPackages.angstrom-lwt-unix
* ocamlPackages.angstrom-async
@vbgl
Copy link
Contributor

vbgl commented Apr 25, 2020 •
edited

@GrahamcOfBorg build ocamlPackages.irmin-unix

@sternenseemann
Copy link
Member Author

sternenseemann commented Apr 26, 2020 •
edited

Might adjust this PR to update directly to 0.14.0 which just came out, if it breaks nothing. Sounds good?

@vbgl
Copy link
Contributor

vbgl commented Apr 26, 2020

Good idea. Thanks.

@sternenseemann
Copy link
Member Author

Angstrom 0.14.0 changed the type of parse_string and parse_bigstring which breaks pretty much every package using angstrom. I guess it's probably easy to patch them, but we could also wait for those problems to be fixed upstream.

@vbgl vbgl merged commit a89afa1 into NixOS:master Apr 28, 2020
@sternenseemann sternenseemann deleted the angstrom branch April 28, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl