Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk-mac-integration: 2.0.8 -> 2.1.3 #85210

Merged
merged 1 commit into from Apr 15, 2020
Merged

gtk-mac-integration: 2.0.8 -> 2.1.3 #85210

merged 1 commit into from Apr 15, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 14, 2020

Motivation for this change

Version update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2020

I don't have a way to test, unfortunately, so please review this.

@veprbl
Copy link
Member

veprbl commented Apr 14, 2020

@GrahamcOfBorg build gtk-mac-integration-gtk2 gtk-mac-integration-gtk3

@prusnak
Copy link
Member Author

prusnak commented Apr 14, 2020

@GrahamcOfBorg build gtk-mac-integration-gtk2 gtk-mac-integration-gtk3

@ofborg ofborg bot requested a review from matthewbauer April 14, 2020 10:09
@prusnak prusnak marked this pull request as ready for review April 14, 2020 19:28
veprbl
veprbl approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by running dia.

nixpkgs-review on x86_64-darwin

3 package marked as broken and skipped:
gimpPlugins.ufraw ufraw zathura

3 package failed to build:
gimp gimpPlugins.gmic haskellPackages.gtk-mac-integration

25 package built:
cherrytree compcert coq_8_5 coq_8_6 coq_8_7 coq_8_8 coq_8_9 darktable dia framac gtk-mac-integration gtk-mac-integration-gtk2 libbap opa prooftree proverif python27Packages.bap python27Packages.gwyddion python27Packages.pygtksourceview python37Packages.bap python38Packages.bap satysfi unison usync why3

@jtojnar jtojnar merged commit 2a19a03 into NixOS:master Apr 15, 2020
@prusnak prusnak deleted the gtk-mac-integration branch April 15, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @veprbl @jtojnar