terminus: 1.0.0-alpha.42 -> 1.0.106 #85212
Conversation
I'm removing myself as maintainer since I don't use terminus anymore. Closes NixOS#85179
ofborg
bot
added
2.status: merge conflict
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
2.status: merge conflict
labels
|
|
||
| wrapProgram $out/bin/terminus \ | ||
| "''${gappsWrapperArgs[@]}" \ | ||
| --prefix XDG_DATA_DIRS : "${gtk3}/share/gsettings-schemas/${gtk3.name}/" \ |
There was a problem hiding this comment.
just add gtk3 and glib and this will be added to gappsWrapperArgs automatically as intended
| wrapProgram $out/bin/terminus \ | ||
| "''${gappsWrapperArgs[@]}" \ | ||
| --prefix XDG_DATA_DIRS : "${gtk3}/share/gsettings-schemas/${gtk3.name}/" \ | ||
| --prefix LD_LIBRARY_PATH : ${libPath} |
There was a problem hiding this comment.
this really shouldn't be done at all (we should use rpath like before).
Have you tried using autoPatchelfHook? It patches things automatically and will check if a dependency that is needed is missing in buildInputs.
There was a problem hiding this comment.
Thanks for your help, but with the proposed changes I'm always getting some kind of error. I'm not that familiar with those functions, and my try-and-error approach is not effective. I copied that approach from the discord derivation. Unfortunately, I don't have time to spend on this, feel free to close this PR if it makes sense to you.
There was a problem hiding this comment.
Totally understandable if you don't want to spend more time on a package you don't use anymore. I believe you could just leave this open for its new maintainer
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
| license = licenses.mit; | ||
| platforms = [ "x86_64-linux" ]; | ||
| homepage = "https://eugeny.github.io/terminus/"; | ||
| maintainers = with maintainers; []; |
There was a problem hiding this comment.
Please add yourself back as a maintainer.
There was a problem hiding this comment.
Related: #85232
I tried to fix the derivation, but it didn't work. I'm removing myself as maintainer because I don't use terminus anymore, and I don't have time to work on this.
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing it, since Terminus has been removed: #134974 and at this point, if someone else wants to add it again, makes more sense to start from a fresh PR |
Motivation for this change
I'm removing myself as maintainer since I don't use terminus anymore.
I also formatted it with nixpkgs-fmt.
I run it locally and looks fine.
Closes #85179
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)