Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpsoffice: 11.1.0.9080 -> 11.1.0.9505 #85211

Merged
merged 7 commits into from Apr 15, 2020
Merged

wpsoffice: 11.1.0.9080 -> 11.1.0.9505 #85211

merged 7 commits into from Apr 15, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Apr 14, 2020 •
edited

Motivation for this change

Updates wpsoffice to the latest version. Switch to autoPatchelfHook should make package more standard. This is based on the hard work done by @Ninlives in #82408.

Closes: #82408
Fixes: #63736

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @Th0rgal

@veprbl veprbl requested a review from Ninlives April 14, 2020 10:27
Ninlives
Ninlives approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@Ninlives Ninlives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but problems listed here #82408 still exist, sadly..

@Ninlives Ninlives mentioned this pull request Apr 15, 2020
Closed
10 tasks
@veprbl
Copy link
Member Author

veprbl commented Apr 15, 2020

LGTM, but problems listed here #82408 still exist, sadly..

Yes, I saw that list. I could only reproduce the first one, but it is present in the 11.1.0.9080 as well. Feel free to open an issue for those, but, ideally, one would need to check with officially supported systems to see if it's an upstream issue.

@veprbl veprbl merged commit 7cc1c2c into NixOS:master Apr 15, 2020
@veprbl veprbl deleted the pr/wpsoffice_11_1_0_9505 branch April 15, 2020 17:53
@Ninlives
Copy link
Contributor

No clue though, I didn't find any related logs..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@Ninlives Ninlives Ninlives approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wpsoffice needs update
3 participants
@veprbl @Ninlives @worldofpeace