Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mastodon-bot: init at 0.0.2 #85234

Closed

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 14, 2020

TODO:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof changed the title <!-- Nixpkgs has a lot of new incoming Pull Requests, but not enough people to review this constant stream. Even if you aren't a committer, we would appreciate reviews of other PRs, especially simple ones like package updates. Just testing the relevant package/service and leaving a comment saying what you tested, how you tested it and whether it worked would be great. List of open PRs: <https://github.com/NixOS/nixpkgs/pulls>, for more about reviewing contributions: <https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions>. Reviewing isn't mandatory, but it would help out a lot and reduce the average time-to-merge for all of us. Thanks a lot if you do! --> ###### Motivation for this change x Apr 14, 2020
@raboof raboof changed the title x mastodon-bot: init at 0.0.1 Apr 14, 2020
@raboof raboof mentioned this pull request Apr 14, 2020
10 tasks
@raboof raboof marked this pull request as draft April 14, 2020 16:32
@raboof raboof force-pushed the nixpkgs-mastodon-bot-init-at-0.0.1 branch from 379bd44 to 38f77c3 Compare April 15, 2020 07:15
@raboof raboof marked this pull request as ready for review April 15, 2020 15:09
@raboof raboof force-pushed the nixpkgs-mastodon-bot-init-at-0.0.1 branch from 38f77c3 to 91dd477 Compare May 7, 2020 07:25
@raboof raboof changed the title mastodon-bot: init at 0.0.1 mastodon-bot: init at 0.0.2 May 7, 2020
@raboof raboof force-pushed the nixpkgs-mastodon-bot-init-at-0.0.1 branch from 91dd477 to 41fbd24 Compare May 15, 2020 08:31
@raboof raboof marked this pull request as draft June 2, 2020 08:32
@raboof
Copy link
Member Author

raboof commented Jun 10, 2020

things changed on master quite a bit, starting fresh here

@raboof raboof closed this Jun 10, 2020
@raboof
Copy link
Member Author

raboof commented Jul 10, 2020

replaced by #92830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant