Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode, vscodium: 1.44.0 -> 1.44.1 #85249

Merged
merged 2 commits into from Apr 17, 2020
Merged

vscode, vscodium: 1.44.0 -> 1.44.1 #85249

merged 2 commits into from Apr 17, 2020

Conversation

kuznero
Copy link
Member

@kuznero kuznero commented Apr 14, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from eadwu and Synthetica9 April 14, 2020 20:44
eadwu
eadwu approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot about this for a day, anyway verified hashes.

@kuznero
Copy link
Member Author

kuznero commented Apr 15, 2020

Please merge as I don't have write access

@kuznero kuznero changed the title vscode: 1.44.0 -> 1.44.1 vscode, vscodium: 1.44.0 -> 1.44.1 Apr 16, 2020
@ofborg ofborg bot requested a review from eadwu April 16, 2020 20:37
eadwu
eadwu approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified hashes.

@kuznero
Copy link
Member Author

kuznero commented Apr 16, 2020

@eadwu please merge as I don't have write access

@kuznero kuznero requested a review from eadwu April 16, 2020 21:41
@eadwu
Copy link
Member

eadwu commented Apr 16, 2020

@worldofpeace @Synthetica9

@worldofpeace worldofpeace merged commit 8d428ac into NixOS:master Apr 17, 2020
@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 17, 2020 •
edited

@kuznero Could you open a backport to stable https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes ? The branch would be release-20.03

@kuznero kuznero mentioned this pull request Apr 17, 2020
Merged
10 tasks
@kuznero kuznero deleted the vscode branch April 20, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kuznero @eadwu @worldofpeace