Skip to content

joplin-desktop: 1.0.179 -> 1.0.200 #85248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2020
Merged

joplin-desktop: 1.0.179 -> 1.0.200 #85248

merged 2 commits into from
Apr 19, 2020

Conversation

HugoReeves
Copy link
Member

Builds successfully on NixOS

Motivation for this change

Joplin desktop was last updated in February and is multiple versions behind. The joplin-desktop repository is changing very quickly and an update is needed, in particular one thing that has improved in more recent versions is the end to end encryption.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS N/A
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rafaelgg @raquelgb

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Builds successfully on NixOS
@ofborg ofborg bot requested a review from raquelgb April 14, 2020 20:46
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 14, 2020

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Apr 16, 2020
@adisbladis adisbladis merged commit 8804e2f into NixOS:master Apr 19, 2020
@HugoReeves HugoReeves deleted the update-joplin-desktop branch April 19, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants