Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 10f4dfcc04b6
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 86d71ddbed42
Choose a head ref
  • 7 commits
  • 4 files changed
  • 2 contributors

Commits on Apr 13, 2020

  1. nixos/networking: fix setting .macAddress and .mtu with networkd 

    This needs to be set in the .linkConfig of a .network
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    cddc7a2 View commit details
    Browse the repository at this point in the history

  2. nixos/networking: add assertion catching setting mac addresses on tun… 

    … devices

Setting a MAC Address on a tun interface isn't supported, and invoking
the corresponding command fails.
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    ca391c8 View commit details
    Browse the repository at this point in the history

  3. nixos/networking: move network-link-${i.name} to scripted networking 

    The unit sets MTU and MAC Address even with networkd enabled, which
isn't necessary anymore, as networkd handles this by itself.
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    5325281 View commit details
    Browse the repository at this point in the history

  4. nixosTests.networking: make routing table comparison more reliable 

    This was whitespace-sensitive, kept fighting with my editor and broke
the tests easily. To fix this, let python convert the output to
individual lines, and strip whitespace from them before comparing.
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    1e19453 View commit details
    Browse the repository at this point in the history

  5. nixosTests.networking.virtual: fix with networkd 

    We only need to wait for network.target to get up, and the
network-addresses-${interfaceName} units are scripted networking only.
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    5150378 View commit details
    Browse the repository at this point in the history

  6. nixosTests.networking: test setting MTU and MAC Address 

    Both the scripted and networkd backend now support setting MTU and MAC
Address, so do this in a test to ensure it doesn't break.
    @flokli
    flokli committed Apr 13, 2020
    Copy the full SHA
    d1edd8b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Merge pull request #85170 from flokli/networking-virtual 

    nixos/networking: fix setting MAC Address and MTU in networkd, fix tests
    @rnhmjoj
    rnhmjoj committed Apr 14, 2020
    Copy the full SHA
    86d71dd View commit details
    Browse the repository at this point in the history