Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.hasql-pool: unbreak #85206

Merged

Conversation

monacoremo
Copy link

Motivation for this change

hasql-pool was marked as broken because of failing tests. The test suite requires running a database server, which is done upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • [ x ] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ currently none, as it was marked as broken ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [ none, as it's a library ] Tested execution of all binary files (usually in ./result/bin/)
  • [ no change ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ no change ] Ensured that relevant documentation is up to date
  • [ x ] Fits CONTRIBUTING.md.

@cdepillabout cdepillabout merged commit 46dada3 into NixOS:haskell-updates Apr 14, 2020
@cdepillabout
Copy link
Member

Thanks for fixing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants