Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.packages.phpc(bf|s): 3.5.3 -> 3.5.4 #85224

Merged
merged 2 commits into from Apr 14, 2020
Merged

php.packages.phpc(bf|s): 3.5.3 -> 3.5.4 #85224

merged 2 commits into from Apr 14, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 14, 2020

Motivation for this change

Also run it with a bigger PHP since it missed some extensions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

etu added 2 commits April 14, 2020 15:14
@etu
php.packages.phpcbf: 3.5.3 -> 3.5.4
2e71139 
Changelog:
https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.4

Also switch to phpWithExtensions because it complained about missing
extensions when running the binary.
@etu
php.packages.phpcs: 3.5.3 -> 3.5.4
83c9620 
Changelog:
https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.4

Also switch to phpWithExtensions because it complained about missing
extensions when running the binary.
@etu etu requested a review from talyz April 14, 2020 13:17
@etu etu changed the title phpc(bf|s): 3.5.3 -> 3.5.4 php.packages.phpc(bf|s): 3.5.3 -> 3.5.4 Apr 14, 2020
talyz
talyz approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified build with nixpkgs-review and tested the binaries. Thanks!

@talyz talyz merged commit 5d2cb15 into NixOS:master Apr 14, 2020
@etu etu deleted the update-php-codesniffer branch April 14, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

@javaguirre javaguirre Awaiting requested review from javaguirre

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @talyz