Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkscape: 0.92.4 → 0.92.5 #85184

Merged
merged 4 commits into from Apr 14, 2020
Merged

inkscape: 0.92.4 → 0.92.5 #85184

merged 4 commits into from Apr 14, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 13, 2020 •
edited

Motivation for this change

https://gitlab.com/inkscape/inkscape/-/tags/INKSCAPE_0_92_5

Last release before 1.0.

I believe the MacOS warnings in changelogs are just regarding the official binaries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar mentioned this pull request Apr 13, 2020
Merged
10 tasks
@jtojnar
inkscape: clean up
38e316d 
The unpackPhase override was only needed when the download server mangled the file extension:

NixOS#23652
@jtojnar
inkscape: format with nixpkgs-fmt
eff936e 
Also order the build inputs alphabetically and switch to pname+version.
@jtojnar
inkscape: 0.92.4 → 0.92.5
a48d86e 
https://gitlab.com/inkscape/inkscape/-/tags/INKSCAPE_0_92_5
@jtojnar
inkscape: add jtojnar as maintainer
a926e73
veprbl
veprbl approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and starts on x86_64-darwin.

nixpkgs-review:

5 package marked as broken and skipped:
btrbk faba-icon-theme mate.mate-utils mojave-gtk-theme udiskie

5 package built:
asciidoc-full asciidoc-full-with-plugins dblatexFull inkscape numix-cursor-theme

@jtojnar jtojnar merged commit 0995d77 into NixOS:master Apr 14, 2020
@jtojnar jtojnar deleted the inkscape-0.92.5 branch April 14, 2020 08:21
@vbgl vbgl mentioned this pull request May 5, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @prusnak @veprbl