Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.03 NixOS release #392

Merged
merged 16 commits into from Apr 20, 2020
Merged

20.03 NixOS release #392

merged 16 commits into from Apr 20, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 13, 2020

Coordinate with NixOS/nixpkgs#66640

deprecating #297

Closes #401 by providing the equivalent change.

@garbas garbas changed the title rename iso-graphical to iso-plasma5 20.03 NixOS release Apr 13, 2020
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i havn't seen a problem except the changed identation i don't understand

i don't understand the Makefile in detail

TODO has to get updated before merge

news.xml Show resolved Hide resolved
news.xml Show resolved Hide resolved
@github-actions
Copy link
Contributor

@garbas garbas marked this pull request as draft April 14, 2020 00:45
@github-actions
Copy link
Contributor

@davidak
Copy link
Member

davidak commented Apr 14, 2020

The rendered pages look good 👍

news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@worldofpeace
Copy link
Contributor

I added numbers to https://hackmd.io/Uy24aMgYThyPIHZWyXGRcA?both

news.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, we just have to wait for the channel.

@garbas garbas marked this pull request as ready for review April 20, 2020 19:58
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@garbas garbas changed the title 20.03 NixOS release 20.03 NixOS release Apr 20, 2020
@garbas garbas requested a review from davidak April 20, 2020 21:25
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i don't see any issues

great text @worldofpeace

@github-actions
Copy link
Contributor

@worldofpeace
Copy link
Contributor

When I look at the deployed website I see 19.09 download links, and the download page says 19.09. The flake is updated and so has the channel. I'm not sure what I'm missing.

samueldr and others added 2 commits April 20, 2020 19:07
The eager update to use 20.03 to *build* the flake accidentally made the
site use the 20.03 manual for a while.

This change allows us to move forward the infrastructure of the site
in preparation for a release, without actually using that version's
manual. This accidental use of an unreleased release should not happen
anymore.

Additionally, it's not much of an issue, the list of AMIs could have
been using the wrong list (of an unreleased branch), though as it
requires manual involvement of the team it wouldn't have been an issue.

Fixes #400.
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

graham saved me
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@worldofpeace
Copy link
Contributor

The final tweaks from IRC, just waiting now...

@worldofpeace worldofpeace merged commit f02e80c into master Apr 20, 2020
@worldofpeace worldofpeace deleted the plasma5-rename branch April 20, 2020 23:27
@worldofpeace
Copy link
Contributor

Thanks @globin for helping me out greatly ❤️

@@ -1,6 +1,117 @@
<?xml version="1.0" encoding="utf-8" ?>

<news>
<item>
<pubDate>TODO</pubDate>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should have been replaced by the actual current timestamp right before merging?

das-g added a commit to das-g/nixos-homepage that referenced this pull request Apr 21, 2020
garbas pushed a commit that referenced this pull request Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants