oneplus-oneplus3: Minor polishing #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samueldr
force-pushed
the
feature/oneplus-oneplus3-polishing
branch
from
d19a0a8
to
e3379a7
Compare
samueldr
force-pushed
the
feature/oneplus-oneplus3-polishing
branch
from
e3379a7
to
f6a8abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off the heels of #126, I started working on oneplus-oneplus3 polishing to figure out Wi-Fi.
The Wi-Fi efforts for now are on pause, but there is some polishing included here that is useful to upstream right now.
This closes #45 as it is functionally equivalent for stage-2 systems,
but with one caveat, there is no stage-1 task implemented yet here to do the equivalent.TODO
Unknowns
Does the LED thing apply to all oneplus3 models? What about the 3T? The device tree files in the repo are confusing.