Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled CUDA support option #85193

Closed

Conversation

alexanderwatanabe
Copy link
Contributor

@alexanderwatanabe alexanderwatanabe commented Apr 14, 2020

Previous commit/push was to master branch. Read docs that I should avoid working out of master, sorry.
Also, set default of cudaSupport to false, (in master I had set it to true) as it seems like a bad idea to assume nvidia card for other users.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Previous commit/push was to master branch. Read docs that I should avoid working out of master, sorry.
Also, set default of cudaSupport to false, (in master I had set it to true) as it seems like a bad idea to assume nvidia card for other users.
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderwatanabe thanks a lot for caring about the CUDA integration here! However, I'm afraid you misunderstood the contribution process for nixpkgs. Let me try to clarify a few things:

  • it's fine to file a PR against master. This is where all the development happens and the nixos-unstable-channel is created from our master. Every "new" change should somehow land on master before appearing on stable branches.
  • you should avoid though to push the changes to your fork's master, instead it's better to create a feature-branch from your master-branch for the following reasons:
    • if the branch name is a bit more descriptive it makes the merge-commit more descriptive as well
    • a lot of people have further customizations on their master or somehow rely on their fork's master which can be a problem if a maintainer pushes minor fixes to a contributor's master before merging a PR.
  • In case you want to backport your changes, please don't file your PR against nixos-20.03, but against release-20.03 instead. The nixos-* branches are created automatically for our channels. You can read more about this on https://howoldis.herokuapp.com/

Does this help you? If not, feel free to ping me either here or in the IRC :)

pkgs/development/libraries/dlib/default.nix Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants