Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libqalculate: 3.8.0 -> 3.9.0 #85216

Closed
wants to merge 1 commit into from
Closed

libqalculate: 3.8.0 -> 3.9.0 #85216

wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/qalculate/libqalculate/releases.

meta.description for libqalculate is: "An advanced calculator library"

meta.homepage for libqalculate is: "http://qalculate.github.io"

Updates performed:

  • Version update

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

83 total rebuild path(s)

28 package rebuild(s)

28 x86_64-linux rebuild(s)
26 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
26 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
kde-cli-tools
kdeplasma-addons
kdev-php
kdev-python
kdevelop
kdevelop-unwrapped
kmenuedit
krohnkite
kwin-tiling
libqalculate
libsForQt5.khotkeys
libsForQt512.khotkeys
nasc
plasma-desktop
plasma-workspace
plasma5.kde-cli-tools
plasma5.kdeplasma-addons
plasma5.khotkeys
plasma5.kmenuedit
plasma5.plasma-desktop
plasma5.plasma-workspace
plasma5.powerdevil
plasma5.systemsettings
powerdevil
qalculate-gtk
rofi-calc
systemsettings
wacomtablet

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libqalculate https://github.com/r-ryantm/nixpkgs/archive/2078f2a0ee7d4712ddcc723daf5662cf9f039403.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0
ls -la /nix/store/7mpq4rshlxgjnr4nv8hs319allmrddl0-libqalculate-3.9.0/bin

Result of nixpkgs-review 1

1 package marked as broken and skipped:
- linuxPackages_hardkernel_4_14.systemtap
1 package failed to build:
- nasc
18 packages built:
- kde-cli-tools
- kdeplasma-addons
- kdev-php
- kdev-python
- kdevelop
- kdevelop-unwrapped
- kmenuedit
- krohnkite
- kwin-tiling
- libqalculate
- plasma5.khotkeys (libsForQt5.khotkeys)
- plasma-desktop
- plasma-workspace
- plasma5.powerdevil
- plasma5.systemsettings
- qalculate-gtk
- rofi-calc
- wacomtablet

cc @gebner for testing.

@ofborg ofborg bot requested a review from gebner April 14, 2020 10:45
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-update-runs-nixpkgs-review-on-every-pr/6701/1

@nh2 nh2 mentioned this pull request Apr 15, 2020
Merged
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/nixpkgs-update-runs-nixpkgs-review-on-every-pr/6701/11

@nh2
Copy link
Contributor

nh2 commented Apr 16, 2020

1 package failed to build:

  • nasc

Seems to truly break nasc and it's not broken on master. Output:

building
build flags: -j2 -l2 SHELL=/nix/store/ffli6m23501dkiznwlkf6n4xvrj02snr-bash-4.4-p23/bin/bash
Scanning dependencies of target qalculatenasc
[  5%] Building CXX object libqalculatenasc/CMakeFiles/qalculatenasc.dir/QalculateNasc.cc.o
/build/source/libqalculatenasc/QalculateNasc.cc: In function 'char* get_function_name(int)':
/build/source/libqalculatenasc/QalculateNasc.cc:38:13: error: 'string' was not declared in this scope; did you mean 'std::string'?
   38 |             string str = ename_r->name;
      |             ^~~~~~
      |             std::string

The problem seems to be a missing using namespace std;.

Perhaps the previous version of libqalculate brought that using in with an #include (that would be bad)?

@nh2
Copy link
Contributor

nh2 commented Apr 16, 2020

Perhaps the previous version of libqalculate brought that using in with an #include (that would be bad)?

I can see no such thing in the upstream diff though. Somebody will have to take a detail look.

@doronbehar
Copy link
Contributor

I opened an issue upstream: parnoldx/nasc#145 .

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-can-i-be-more-useful-at-reviewing-pull-requests/6731/3

@gebner gebner mentioned this pull request May 4, 2020
Closed
doronbehar
doronbehar approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know why, but now when rebased on latest master, nasc builds and runs fine for me.

@doronbehar
Copy link
Contributor

@jtojnar I'm pretty sure nasc builds fine now when the PR is rebased on latest master, I'm not sure how that got fixed but let's see:

@GrahamcOfBorg build nasc

@r-ryantm r-ryantm closed this Jun 11, 2020
@r-ryantm r-ryantm deleted the auto-update/libqalculate branch June 11, 2020 04:55
@ryantm ryantm restored the auto-update/libqalculate branch June 11, 2020 05:19
@ryantm ryantm reopened this Jun 11, 2020
@r-ryantm r-ryantm closed this Jun 14, 2020
@r-ryantm r-ryantm deleted the auto-update/libqalculate branch June 14, 2020 03:30
@ryantm ryantm restored the auto-update/libqalculate branch June 14, 2020 04:09
@ryantm ryantm reopened this Jun 14, 2020
@r-ryantm r-ryantm closed this Jul 1, 2020
@r-ryantm r-ryantm deleted the auto-update/libqalculate branch July 1, 2020 04:38
@ryantm ryantm restored the auto-update/libqalculate branch July 1, 2020 05:02
@ryantm ryantm reopened this Jul 1, 2020
@doronbehar
Copy link
Contributor

ofborg's nasc's build was successful.

@gebner gebner mentioned this pull request Aug 22, 2020
Merged
10 tasks
@r-ryantm r-ryantm deleted the auto-update/libqalculate branch August 24, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@r-ryantm @nixos-discourse @nh2 @doronbehar @ryantm