Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer: 2020-04-06 -> 2020-04-20 #85243

Merged
merged 2 commits into from Apr 23, 2020
Merged

rust-analyzer: 2020-04-06 -> 2020-04-20 #85243

merged 2 commits into from Apr 23, 2020

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Apr 14, 2020

Motivation for this change

Bump rust-analyzer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oxalica oxalica requested a review from jonringer as a code owner April 14, 2020 18:56
jonringer
jonringer reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes to pkgs/development/node-packages/node-packages-v12.nix are not really needed

@HugoReeves
Copy link
Member

Thanks for packaging rust-analyzer!
Was able to build and execute on NixOS and MacOS Catalina.

I'm not involved with any of these packages, but, I believe removing quotes around the URLs in nodePackages is probably not a good idea. I think I read somewhere that future versions of the Nix language might look to remove the special syntax for URLs, so keeping the URLs in quotes is probably a good idea.

You're also changing a package which isn't really associated with rust-analyzer, so if you want to make the edits to nodePackages they should probably get their own PR.
Just my thoughts, thanks again.

@oxalica
Copy link
Contributor Author

oxalica commented Apr 15, 2020

@jonringer
Actually yes, but the generator updates all of them. Only node-packages-v10.nix is used by vscode-extensions.rust-analyzer and should be updated.
So should I only update v10 packages here?

@oxalica
Copy link
Contributor Author

oxalica commented Apr 21, 2020

2020-04-20 is released, but blocked by #85618.

@oxalica oxalica changed the title rust-analyzer: 2020-04-06 -> 2020-04-13 rust-analyzer: 2020-04-06 -> 2020-04-20 Apr 23, 2020
@oxalica oxalica requested a review from jonringer April 23, 2020 09:12
@oxalica
Copy link
Contributor Author

oxalica commented Apr 23, 2020

@jonringer Bumped to 2020-04-20 and upgrade only node-packages-v10.nix now.

@Mic92 Mic92 merged commit 11019ea into NixOS:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxalica @HugoReeves @jonringer @Mic92