Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: e5ea01c1a8bb
Choose a base ref
...
head repository: NixOS/nix
compare: c0c2cb871d09
Choose a head ref
  • 13 commits
  • 8 files changed
  • 6 contributors

Commits on Apr 9, 2020

  1. gc.cc: Ignore hidden files in temproots

    Philipp Middendorf committed Apr 9, 2020
    Copy the full SHA
    04bedda View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3482 from pmiddend/ignore-hidden-files-in-temproots

    gc.cc: Ignore hidden files in temproots
    edolstra committed Apr 9, 2020
    Copy the full SHA
    f46cb68 View commit details
    Browse the repository at this point in the history
  3. Delete temporary directory on successful build

    With --check and the --keep-failed (-K) flag, the temporary directory
    was being retained regardless of whether the build was successful and
    reproducible.  This removes the temporary directory, as expected, on
    a reproducible check build.
    
    Added tests to verify that temporary build directories are not
    retained unnecessarily, particularly when using --check with
    --keep-failed.
    tollb committed Apr 9, 2020
    Copy the full SHA
    16a4864 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2020

  1. Merge pull request #2689 from tollb/fix/delete_tmp_dir_when_build_che…

    …ck_ok
    
    Delete temporary directory on successful build
    domenkozar committed Apr 10, 2020
    Copy the full SHA
    db25a6d View commit details
    Browse the repository at this point in the history
  2. Update release script

    edolstra committed Apr 10, 2020
    Copy the full SHA
    3abf6d0 View commit details
    Browse the repository at this point in the history
  3. Fix nix-build --check -K in sandbox w/o root

    Temporarily add user-write permission to build directory so that it
    can be moved out of the sandbox to the store with a .check suffix.
    
    This is necessary because the build directory has already had its
    permissions set read-only, but write permission is required
    to update the directory's parent link to move it out of the sandbox.
    
    Updated the related --check "derivation may not be deterministic"
    messages to consistently use the real store paths.
    
    Added test for non-root sandbox nix-build --check -K to demonstrate
    issue and help prevent regressions.
    tollb committed Apr 10, 2020
    Copy the full SHA
    8132d0a View commit details
    Browse the repository at this point in the history
  4. Add test case for temporary directories on darwin

    A test case for correct handling of temporary directory deletion that
    was added to check.sh as part of PR #2689 was initially disabled for
    Darwin because of a directory permission issue in PR #2688.
    
    Now that the issue in PR #2688 is fixed, this commit enables the test
    case for Darwin.
    tollb committed Apr 10, 2020
    Copy the full SHA
    e8bd1bc View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2020

  1. Copy the full SHA
    fc14213 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3447 from DavHau/improve-tofile-error-msg

    improve toFile error message when containing potential drv path
    domenkozar committed Apr 11, 2020
    Copy the full SHA
    fc14424 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2688 from tollb/fix/build_check_keep_failed_sandb…

    …ox_perms
    
    Fix nix-build --check -K in sandbox w/o root
    domenkozar committed Apr 11, 2020
    Copy the full SHA
    ea2148f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2020

  1. never use /var/folders for TMPDIR on darwin

    This doesn't just cause problems for nix-store --serve but also results
    in certain build failures. Builds that use unix domain sockets in their
    tests often fail because the /var/folders prefix already consumes more
    than half of the maximum length of socket paths.
    
        struct sockaddr_un {
           sa_family_t sun_family;               /* AF_UNIX */
           char        sun_path[108];            /* Pathname */
        };
    LnL7 committed Apr 12, 2020
    Copy the full SHA
    4d9db42 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3488 from LnL7/darwin-tmpdir

    never use /var/folders for TMPDIR on darwin
    edolstra committed Apr 12, 2020
    Copy the full SHA
    512753f View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Copy the full SHA
    c0c2cb8 View commit details
    Browse the repository at this point in the history