Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.postgrest: unbreak #85230

Merged
merged 1 commit into from Apr 15, 2020
Merged

haskellPackages.postgrest: unbreak #85230

merged 1 commit into from Apr 15, 2020

Conversation

monacoremo
Copy link

Motivation for this change

With hasql-pool unbroken (#85206), the postgrest package that depends on it is also no longer broken.

Like with hasql-pool, the postgrest test suite depends on running a database server. dontCheck had already been set a while back with e5ff242.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ none ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ no changes ] Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@monacoremo monacoremo mentioned this pull request Apr 14, 2020
Closed
@cdepillabout
Copy link
Member

Works for me, thanks for fixing this up!

@cdepillabout cdepillabout merged commit 5ba7a1e into NixOS:haskell-updates Apr 15, 2020
@monacoremo
Copy link
Author

Many thanks for your quick review @cdepillabout !

@monacoremo monacoremo deleted the monacoremo-unbreak-postgrest branch April 15, 2020 05:47
@glasserc glasserc mentioned this pull request May 17, 2020
Closed
@monacoremo monacoremo mentioned this pull request Dec 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monacoremo @cdepillabout