Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: first version of the web front-end to new BaNaNaS server. #2

Merged
merged 9 commits into from Apr 14, 2020

Conversation

frosch123
Copy link
Member

No description provided.

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, if you fix thes things up, and move the TODOs to a wishlist, I am okay with accepting this PR. It might still not be finished, but it might make it easier to cooperate on this.

README.md Outdated Show resolved Hide resolved
webclient/pages/package_info.py Outdated Show resolved Hide resolved
webclient/pages/package_info.py Outdated Show resolved Hide resolved
webclient/pages/package_list.py Outdated Show resolved Hide resolved
webclient/pages/version_info.py Outdated Show resolved Hide resolved
webclient/pages/version_info.py Outdated Show resolved Hide resolved
webclient/pages/version_info.py Outdated Show resolved Hide resolved
webclient/templates/base.html Outdated Show resolved Hide resolved
webclient/templates/manager_new_package.html Outdated Show resolved Hide resolved
Note: Some of the info is filled automatically after uploading the files.

<table>
<tr><td>Content Id</td><td>{{ version["content-type"] }}/{{ version["unique-id"] }}/{{ version["md5sum-partial"] }}</td></tr>
Copy link
Contributor

@auge8472 auge8472 Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose a table-less construction. If the table is kept, the first cell in a row is a th and it's content should be a label if it is the name of a matching form field (not in this row).

<tr>
  <th><label for="input-name">Name</label></th>
  <td>… <input … id="input-name" /></td>
</tr>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this to someone who makes a proper layout with CSS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means that, if you like, you can now make a PR to fix these bits and pieces :) A more useful workflow than trying to explain what should be fixed, I am sure :D Tnx a bunch @auge8472 !

{% endif %}

<button type="submit" name="validate">Validate</button>
<button type="submit" name="publish">Publish</button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type "submit" is the default type of the element button and can therefore be ommited.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does help to represent the intention. So I am happy it is there. At least makes it clear there was no mistake :)

Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this to master, so others can make PRs to fix things. That sounds more useful :)

@frosch123 frosch123 marked this pull request as ready for review April 14, 2020 19:51
@frosch123 frosch123 merged commit 0b71a23 into OpenTTD:master Apr 14, 2020
@frosch123 frosch123 deleted the dev branch April 14, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants