Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing golden.pb_type.xml in some test cases #40

Open
daniellimws opened this issue Apr 14, 2020 · 4 comments
Open

Missing golden.pb_type.xml in some test cases #40

daniellimws opened this issue Apr 14, 2020 · 4 comments
Assignees
@acomodi @mkurc-ant

Comments

@daniellimws
Copy link
Collaborator

A lot of test cases in tests/clocks and the one in tests/simple_pll do not have golden.pb_type.xml.

Are these test cases incomplete?
@daniellimws
Copy link
Collaborator Author

Additionally, the names for modules in tests/clocks are module BLOCK instead of module FILENAME. This causes pytest to fail when a golden.pb_type.xml file is added.

@mithro
Copy link
Collaborator

mithro commented Apr 15, 2020

@mkurc-ant - Do you know if these where a WIP or?

@mithro
Copy link
Collaborator

mithro commented Apr 15, 2020 •
edited by unfurl-links bot

Looks like they might have come in via https://github.com/SymbiFlow/symbiflow-arch-defs/pull/316/files which was written by @acomodi?

GitHub
This PR relates to the V2X tools to generate the XML models and pb_types necessary to have the architecture XML definition of the design. The tasks to be done are the following:

Generate direct pi...

@mkurc-ant
Copy link
Contributor

@mithro I can fix these tests. Some tests do not have either golden model or pb_type as they are meant to test only the one that is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acomodi acomodi

@mkurc-ant mkurc-ant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mithro @daniellimws @acomodi @mkurc-ant