Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniserve: build on darwin #85187

Merged
merged 1 commit into from Apr 14, 2020
Merged

miniserve: build on darwin #85187

merged 1 commit into from Apr 14, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 13, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Apr 13, 2020
@ofborg ofborg bot requested a review from NeQuissimus April 13, 2020 23:54
@veprbl
Copy link
Member

veprbl commented Apr 14, 2020

@GrahamcOfBorg build miniserve

veprbl
veprbl approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-darwin

@veprbl veprbl merged commit 1a3d41d into NixOS:master Apr 14, 2020
@zowoq zowoq deleted the miniserve branch April 14, 2020 04:48
jappeace pushed a commit to jappeace/nixpkgs that referenced this pull request Apr 17, 2020
@zowoq @jappeace
miniserve: build on darwin (NixOS#85187)
d488a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @veprbl