-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: first version of the web front-end to new BaNaNaS server. #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, if you fix thes things up, and move the TODOs to a wishlist, I am okay with accepting this PR. It might still not be finished, but it might make it easier to cooperate on this.
…ures not targeted for v1.
Note: Some of the info is filled automatically after uploading the files. | ||
|
||
<table> | ||
<tr><td>Content Id</td><td>{{ version["content-type"] }}/{{ version["unique-id"] }}/{{ version["md5sum-partial"] }}</td></tr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would propose a table-less construction. If the table is kept, the first cell in a row is a th
and it's content should be a label
if it is the name of a matching form field (not in this row).
<tr>
<th><label for="input-name">Name</label></th>
<td>… <input … id="input-name" /></td>
</tr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this to someone who makes a proper layout with CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That means that, if you like, you can now make a PR to fix these bits and pieces :) A more useful workflow than trying to explain what should be fixed, I am sure :D Tnx a bunch @auge8472 !
{% endif %} | ||
|
||
<button type="submit" name="validate">Validate</button> | ||
<button type="submit" name="publish">Publish</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type "submit" is the default type of the element button
and can therefore be ommited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does help to represent the intention. So I am happy it is there. At least makes it clear there was no mistake :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this to master, so others can make PRs to fix things. That sounds more useful :)
No description provided.