Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneplus3: Enable otg-switch #45

Closed
wants to merge 1 commit into from

Conversation

kirelagin
Copy link
Member

No description provided.

@samueldr samueldr added the 4. type: enhancement New feature or request label Nov 19, 2019
@samueldr
Copy link
Member

This is blocked by the same implementation details as in #62.

The main reason is that the docs building is using the default.nix "device description" without actually having the full modules system started up, and the current changes breaks documentation generation.

 $ nix-build ./doc/
[...]
 - oneplus-oneplus3
error: undefined variable 'AFTER_DEVICE_INIT' at /nix/store/jnwcp2d87wkmmc3vdh9790y9pnrjp1m6-devices/oneplus-oneplus3/default.nix:45:25
builder for '/nix/store/r6wdkbgr5z33xm421hbnm6s1k9y3zhba-mobile-nixos-docs-devices.drv' failed with exit code 1
cannot build derivation '/nix/store/11sj1a740dlfl4694c418m65mhac6d3j-mobile-nixos-docs.drv': 1 dependencies couldn't be built
error: build of '/nix/store/11sj1a740dlfl4694c418m65mhac6d3j-mobile-nixos-docs.drv' failed
Command exited with non-zero status 100

Though the change is appropriate, and it looks like it's likely a family-wide issue:

Though it's not the same /sys/ file. Hmm.

At the very least, I'll be thinking about the appropriate fix for this class of problem, and re-doing this change accordingly. It's also nice that I have the device to test on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants