Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php.packages.phpstan: 0.12.14 -> 0.12.18 #85226

Merged
merged 1 commit into from Apr 14, 2020
Merged

php.packages.phpstan: 0.12.14 -> 0.12.18 #85226

merged 1 commit into from Apr 14, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Apr 14, 2020

Motivation for this change

Changelog: https://github.com/phpstan/phpstan/releases/tag/0.12.18

Also switch to phpWithExtensions because it complained about missing
extensions when running the binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu
php.packages.phpstan: 0.12.14 -> 0.12.18
1b1d292 
Changelog: https://github.com/phpstan/phpstan/releases/tag/0.12.18

Also switch to phpWithExtensions because it complained about missing
extensions when running the binary.
@etu etu requested a review from talyz April 14, 2020 13:23
talyz
talyz approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works as expected. Thanks!

@talyz talyz merged commit 3dbfa91 into NixOS:master Apr 14, 2020
@etu etu deleted the update-phpstan branch April 14, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @talyz