Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o: 1.17.1 -> 1.17.3 #85201

Merged
merged 1 commit into from Apr 14, 2020
Merged

cri-o: 1.17.1 -> 1.17.3 #85201

merged 1 commit into from Apr 14, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 14, 2020 •
edited

Motivation for this change

Update CRI-O to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
cri-o: 1.17.1 -> 1.17.3
392b2a1 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

saschagrunert commented Apr 14, 2020 •
edited

@zowoq @vdemeester do we want to add this package to the general containers team as well?

@vdemeester
Copy link
Member

@zowoq @vdemeester do we want to add this package to the general containers team as well?

I would think so yes 😉

vdemeester
vdemeester approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@zowoq
Copy link
Contributor

zowoq commented Apr 14, 2020

Maybe have another team to cover kubernetes packages and modules?

@marsam marsam merged commit f648392 into NixOS:master Apr 14, 2020
@marsam
Copy link
Contributor

marsam commented Apr 14, 2020

what do you think of renaming the team to containers or container-tools?

@zowoq
Copy link
Contributor

zowoq commented Apr 14, 2020

I'd rather have more teams than increase the scope of the existing team.

@saschagrunert saschagrunert deleted the crio branch April 14, 2020 13:49
@saschagrunert
Copy link
Member Author

Sounds both good to me 🤷

@zowoq
Copy link
Contributor

zowoq commented Apr 23, 2020

Now that we are sharing config between modules this seems necessary.

In addition to cri-o I suggest adding these to the podman team:

nixos/cri-o, cri-tools, cni-plugins

I'd prefer not to add any further packages or modules (unless they are very relevant) as I'd be concerned that the team would become a generic containers/Docker/Kubernetes/etc group with lots of maintainers and packages and I think that would decrease its usefulness.

@saschagrunert
Copy link
Member Author

Yes, I agree @zowoq

@zowoq zowoq mentioned this pull request Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saschagrunert @vdemeester @zowoq @marsam