Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/unit: update service configuration and update unit to 1.17 #85225

Merged
merged 7 commits into from May 6, 2020
Merged

nixos/unit: update service configuration and update unit to 1.17 #85225

merged 7 commits into from May 6, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 14, 2020 •
edited

Motivation for this change

Fixed startup service.
Update sandboxing mode - change to "strict" mode and add option to allow writing to custom directories
Running Unit from root - in latest release recommended not set ambient capabilities.
Add simple unit-php test.
Update unit to 1.17

cc @Mic92 @flokli @aanderse

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin force-pushed the nginx-unit branch 2 times, most recently from d4df835 to f97ddfc Compare April 14, 2020 17:53
@Izorkin Izorkin force-pushed the nginx-unit branch 3 times, most recently from 749a877 to c069019 Compare April 16, 2020 17:33
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 16, 2020

Added unit-php test.
@aanderse @etu please recheck.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 16, 2020

@GrahamcOfBorg test php.unit

@Izorkin Izorkin changed the title nixos/unit: update service configuration nixos/unit: update service configuration and update unit to 1.17 Apr 16, 2020
@Izorkin Izorkin requested a review from aanderse April 18, 2020 18:46
@Izorkin Izorkin force-pushed the nginx-unit branch 3 times, most recently from 4c8437a to 79d8fdc Compare April 23, 2020 12:43
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@GrahamcOfBorg test php.unit

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@GrahamcOfBorg eval

etu
etu reviewed Apr 24, 2020
View reviewed changes
nixos/tests/php/default.nix Outdated Show resolved Hide resolved
etu
etu reviewed Apr 24, 2020
View reviewed changes
nixos/tests/php/unit.nix Outdated Show resolved Hide resolved
etu
etu reviewed Apr 24, 2020
View reviewed changes
nixos/tests/php/unit.nix Outdated Show resolved Hide resolved
@Izorkin Izorkin force-pushed the nginx-unit branch 3 times, most recently from b441f21 to 6b140c6 Compare April 24, 2020 06:01
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test unit-php

@Izorkin Izorkin requested a review from etu April 27, 2020 18:57
@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 29, 2020

Fixed conflicting files

@Izorkin Izorkin force-pushed the nginx-unit branch 3 times, most recently from 99e3410 to 5853ccb Compare April 30, 2020 05:56
@Mic92
Copy link
Member

Mic92 commented May 6, 2020

Result of nixpkgs-review pr 85225 1

1 package built:
- unit

@Mic92 Mic92 merged commit 5487e15 into NixOS:master May 6, 2020
@Izorkin Izorkin deleted the nginx-unit branch May 6, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@flokli flokli flokli requested changes

@aanderse aanderse Awaiting requested review from aanderse

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Izorkin @Mic92 @flokli @etu @aanderse