Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.zimports: init at 0.2.0 #85176

Merged
merged 1 commit into from Apr 17, 2020
Merged

python.pkgs.zimports: init at 0.2.0 #85176

merged 1 commit into from Apr 17, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 13, 2020 •
edited

Motivation for this change

The author gives a pretty good overview of why one would want to use
zimports over other import organizers:

https://github.com/sqlalchemyorg/zimports/tree/0.2.0#zzzeek-why-are-you-writing-one-of-these-there-are-a-dozen-pep8-import-fixers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
python.pkgs.zimports: init at 0.2.0
c26ee28 
The author gives a pretty good overview of why one would want to use
zimports over other import organizers:

https://github.com/sqlalchemyorg/zimports/tree/0.2.0#zzzeek-why-are-you-writing-one-of-these-there-are-a-dozen-pep8-import-fixers
@timokau
Copy link
Member Author

timokau commented Apr 13, 2020

It is noteworthy that the author considers zimports "done" (sqlalchemyorg/zimports#10 (comment)) and it has very few dependencies. That should make it easy to maintain.

@timokau timokau merged commit 42ca7c1 into NixOS:master Apr 17, 2020
@timokau timokau deleted the zimports-init branch April 17, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau