Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/xss-lock: add package to systemPackages when the module is ena… #85202

Closed
wants to merge 1 commit into from
Closed

module/xss-lock: add package to systemPackages when the module is ena… #85202

wants to merge 1 commit into from

Conversation

nschoe
Copy link
Contributor

@nschoe nschoe commented Apr 14, 2020

I believe xss-lock was missing being added to systemPackages when it is enabled. I've checked with other modules, and they all seem to be added.

I've made this change from the nixos-20.03 branch and tested it.

I'm pretty new to submitting changes to nixpkgs, don't hesitate to tell me if this is not the correct PR (I'm a bit lost between master, nixos-20.03, release-20.03, etc.)

cc @malyn

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evenbrenden
Copy link
Contributor

My guess is that xss-lock is not added to the environment because there isn't any reason to run more than one instance of it. What is your use case for this change (and does it make sense to add it as a configuration instead)?

@stale
Copy link

stale bot commented Jan 17, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 17, 2021
@doronbehar
Copy link
Contributor

Closing because OP hasn't responded and this is stale and the target branch should be master.

@doronbehar doronbehar closed this Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nschoe @evenbrenden @doronbehar