Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "lib/options: Use escapeNixIdentifier for showOption" #85241

Merged
merged 2 commits into from Apr 15, 2020
Merged

Revert "lib/options: Use escapeNixIdentifier for showOption" #85241

merged 2 commits into from Apr 15, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 14, 2020

Motivation for this change

This is used in in the manual generation for option identifiers that can
be linked. This, unike what the example describes, doesn't preserve
quotes which is needed for these identifiers to be valid.

/cc @infinisil @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
Revert "lib/options: Use escapeNixIdentifier for showOption"
31a03da 
This is used in in the manual generation for option identifiers that can
be linked. This, unike what the example describes, doesn't preserve
quotes which is needed for these identifiers to be valid.

This reverts commit 124cccb.
@LnL7 LnL7 changed the title Show option Revert "lib/options: Use escapeNixIdentifier for showOption" Apr 14, 2020
@infinisil infinisil merged commit 9f2463c into NixOS:master Apr 15, 2020
@infinisil infinisil mentioned this pull request Apr 15, 2020
Merged
1 task
@LnL7 LnL7 deleted the show-option branch April 15, 2020 10:16
@infinisil infinisil mentioned this pull request Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @infinisil