Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wifite2: 2.2.5 -> 2.5.2 #85240

Merged
merged 2 commits into from Apr 14, 2020
Merged

wifite2: 2.2.5 -> 2.5.2 #85240

merged 2 commits into from Apr 14, 2020

Conversation

danielfullmer
Copy link
Contributor

The kimocoder repo is more recently updated, and is the one used by
Debian Linux as well:
See the "Homepage" link on https://packages.debian.org/sid/net/wifite

Additionally, I've enabled the tests, which has the added benefit of failing if the necessary tools are not available.

CC @Lassulus

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielfullmer
wifite2: 2.2.5 -> 2.5.2
7e46e2a 
The kimocoder repo is more recently updated, and is the one used by
Debian / Kali Linux as well.
@ofborg ofborg bot requested a review from Lassulus April 14, 2020 18:42
@Lassulus
Copy link
Member

thanks, very nice!
can you add yourself to maintainers aswell? only if you want to though. I wanted to package this for my autowifi manger but never came around to actually use it.

@danielfullmer
Copy link
Contributor Author

Sure, no problem!

Lassulus
Lassulus approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review

@Lassulus Lassulus merged commit c7348b0 into NixOS:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfullmer @Lassulus