-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look at Rigidbody.centerOfMass. #2604
Conversation
@@ -239,6 +239,18 @@ internal class MainWindow : VesselSupervisedWindowRenderer { | |||
|
|||
private void RenderKSPFeatures() { | |||
if (show_2519_debugging_ui) { | |||
string offsets = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we revert changes to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted show_2519_debugging_ui
.
ksp_plugin/part.cpp
Outdated
centre_of_mass_ = centre_of_mass; | ||
} | ||
|
||
RigidMotion<RigidPart, EccentricPart> Part::ToEccentric() const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find the name very clear. Maybe rigid_to_eccentric_motion
would read better at the call site?
Also, I would invest in a member variable (and serialize it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, MakeRigidToEccentricMotion
, and no.
Fix #2560.