Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pylibftdi: 0.18.1 -> 0.19.0 #90703

Closed
wants to merge 1 commit into from
Closed

python3Packages.pylibftdi: 0.18.1 -> 0.19.0 #90703

wants to merge 1 commit into from

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Jun 18, 2020 •
edited

Motivation for this change

pylibftdi has moved to github. This also updates to the newest release (0.19.0).

Things done

I've tested this with some simple code using real FTDI devices and it works fine.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 7, 2020

Superseded.

@risicle risicle closed this Sep 7, 2020
@risicle
Copy link
Contributor

risicle commented Sep 7, 2020

Actually, didn't realize this is more than just a bump. Will need a rebase though.

@risicle risicle reopened this Sep 7, 2020
@matthuszagh
Copy link
Contributor Author

matthuszagh commented Sep 7, 2020 •
edited

@risicle mind posting the PR this PR would have been superseded by? I'll rebase when I'm back at a computer Wednesday.

@risicle
Copy link
Contributor

risicle commented Sep 7, 2020 •
edited

That would be... fe87c80, part of a bulk-update.

@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@siraben siraben closed this Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthuszagh @risicle @ryantm @siraben