Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enlightenment: efreet icons not caching #90687

Merged
merged 1 commit into from Jul 9, 2020

Conversation

bagnaram
Copy link
Contributor

@bagnaram bagnaram commented Jun 17, 2020

Motivation for this change

Efreet does not handle icon caching properly in Nixos due to mtime forced to 0.

Things done

Implemented a patch from Carsten Haitzlerraster@rasterman.com to change how efreetd scans for changes in the filesystem and updates the efreetd cache.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ X] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • [X ] Fits CONTRIBUTING.md.

@bagnaram bagnaram changed the title Fix/enlightenment efreet icons WIP: Fix/enlightenment efreet icons Jun 17, 2020
@bagnaram bagnaram changed the title WIP: Fix/enlightenment efreet icons Enlightenment: Fix/enlightenment efreet icons Jun 29, 2020
@bagnaram
Copy link
Contributor Author

Increased EFL to 1.24.3 to support upstream patch

@bagnaram bagnaram changed the title Enlightenment: Fix/enlightenment efreet icons enlightenment: enlightenment efreet icons not displaying Jun 29, 2020
@bagnaram bagnaram changed the title enlightenment: enlightenment efreet icons not displaying enlightenment: efreet icons not caching Jun 29, 2020
@romildo
Copy link
Contributor

romildo commented Jun 30, 2020

Please, format the commit messages according to the guidelines at Submitting changes.

(Efreet work-around for mtime 0)
@bagnaram bagnaram force-pushed the fix/enlightenment-efreet-icons branch from fd0a00c to 2e3584b Compare June 30, 2020 02:44
@bagnaram
Copy link
Contributor Author

bagnaram commented Jul 9, 2020

Any further actions on this PR?

@romildo romildo merged commit c755302 into NixOS:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants