Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces/intervention-reporting.idl and test #24202

Merged
merged 1 commit into from Jul 10, 2020

Conversation

stephenmcgruer
Copy link
Contributor

Closes #24193

@foolip
Copy link
Member

foolip commented Jun 24, 2020

Per https://wpt.fyi/results/intervention-reporting?sha=bbfa81ff2b&label=pr_head no implementation supports any of this. Is this intended to be exposed to the web?

@stephenmcgruer
Copy link
Contributor Author

Is this intended to be exposed to the web?

cc @clelland for this question

@clelland
Copy link
Contributor

clelland commented Jul 9, 2020

Chromium's IDL has this marked as NoInterfaceObject, so that's not exposed. That's been deprecated in WebIDL though, so we should probably remove that attribute.

Objects of this type are web-exposed; they're what you'd see as the body attribute of an intervention report delivered via a reporting observer.

@stephenmcgruer
Copy link
Contributor Author

Thanks Ian; we should merge this then and let Chromium fail it until its IDL is fixed.

Ping @foolip for review :)

@stephenmcgruer stephenmcgruer merged commit cce6211 into master Jul 10, 2020
@stephenmcgruer stephenmcgruer deleted the idlharness-intervention-reporting branch July 10, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants