Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: add coreutils to PATH #90673

Merged
merged 1 commit into from Jun 17, 2020
Merged

google-chrome: add coreutils to PATH #90673

merged 1 commit into from Jun 17, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jun 17, 2020 •
edited

google-chrome-stable can't run without coreutils in PATH

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
google-chrome: add coreutils to PATH
e8ddc0c 
google-chrome-stable can't run without coreutils in PATH
@ofborg ofborg bot requested a review from msteen June 17, 2020 12:42
@grahamc grahamc merged commit 38e990d into NixOS:master Jun 17, 2020
@grahamc grahamc deleted the google-chrome-path branch June 17, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msteen msteen Awaiting requested review from msteen

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@grahamc