Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

json_c: add patch for CVE-2020-12762 #90688

Merged
merged 1 commit into from Jun 18, 2020
Merged

json_c: add patch for CVE-2020-12762 #90688

merged 1 commit into from Jun 18, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 17, 2020

Motivation for this change

Fixes: https://nvd.nist.gov/vuln/detail/CVE-2020-12762
Details: json-c/json-c#592

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" ... ~750 pkgs:(
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata requested a review from lovek323 June 17, 2020 20:10
@mmilata mmilata added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 17, 2020
worldofpeace
worldofpeace reviewed Jun 18, 2020
View reviewed changes
pkgs/development/libraries/json-c/default.nix
@@ -7,6 +7,14 @@ stdenv.mkDerivation rec {
sha256 = "0ch1v18wk703bpbyzj7h1mkwvsw4rw4qdwvgykscypvqq10678ll";
};

patches = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link to https://nvd.nist.gov/vuln/detail/CVE-2020-12762?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link.

@worldofpeace
Copy link
Contributor

@mmilata Isn't the attribute json_c and not json-c as the commit suggests? Could we change that?

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build json_c

@mmilata
Copy link
Member Author

mmilata commented Jun 18, 2020

@worldofpeace right, sorry, fixed

@worldofpeace worldofpeace changed the title json-c: add patch for CVE-2020-12762 json_c: add patch for CVE-2020-12762 Jun 18, 2020
@worldofpeace worldofpeace merged commit bb0e70f into NixOS:staging Jun 18, 2020
@worldofpeace
Copy link
Contributor

Thanks @mmilata

@mmilata mmilata deleted the json-c-cve-2020-12762 branch June 18, 2020 01:19
@mmilata mmilata mentioned this pull request Jun 18, 2020
Merged
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @worldofpeace @TredwellGit