Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse: 0.11.0 -> 0.11.1 #90666

Merged
merged 1 commit into from Jun 19, 2020
Merged

reuse: 0.11.0 -> 0.11.1 #90666

merged 1 commit into from Jun 19, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jun 17, 2020

Motivation for this change

https://github.com/fsfe/reuse-tool/releases/tag/v0.11.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from FlorianFranzen June 17, 2020 10:50
@Luflosi
Copy link
Contributor Author

Luflosi commented Jun 19, 2020

Maybe @ehmry?

@ehmry ehmry merged commit ff51213 into NixOS:master Jun 19, 2020
@Luflosi Luflosi deleted the update/reuse branch June 19, 2020 16:48
@Luflosi
Copy link
Contributor Author

Luflosi commented Jun 19, 2020

Thanks ❤️.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianFranzen FlorianFranzen Awaiting requested review from FlorianFranzen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @ehmry