Bridge management #158
Open
Bridge management #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werbfred
changed the title
Closed
|
Probably needs documenting somewhere (newgrf-wiki?) and ideally it should be tested as well... |
glx22
reviewed
Jun 17, 2020
| 'max_length' : { 'num': 0x0A, 'size': 1 }, | ||
| # 0x0B - cost factor (old way) | ||
| 'speed_limit' : { 'num': 0x0C, 'size': 2, 'unit_type': 'speed', 'unit_conversion': (5000, 1397), 'adjust_value': lambda val, unit: ottd_display_speed(val, 1, unit)}, | ||
| 'sprite' : { 'num': 0x0D, 'size': 2 }, |
There was a problem hiding this comment.
This seems wrong, based on my reading of the specs.
There was a problem hiding this comment.
Hmm... I did it based on https://newgrf-specs.tt-wiki.net/wiki/Action0/Bridges
What is wrong according to you?
There was a problem hiding this comment.
prop 0D is not a simple 2 bytes value, it's more complex. See the example at the bottom of the page.
There was a problem hiding this comment.
Sprites are clearly wrong... Need to find some to generate output, will be able to share full version then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested all except
spriteandflags...The code to edit a bridge becomes 馃憤
name,description_rail_bridgeanddescription_road_bridgehave also been tested and working fine.