Reserve the __contentAddressed derivation parameter
#3710
Conversation
Not implementing anything here, just throwing an error if a derivation sets `__contentAddressed = true` without `--experimental-features content-addressed-paths` (and also with it as there's nothing implemented yet)
src/libstore/build.cc
Outdated
| @@ -1195,6 +1198,14 @@ void DerivationGoal::haveDerivation() | |||
|
|
|||
| parsedDrv = std::make_unique<ParsedDerivation>(drvPath, *drv); | |||
|
|
|||
| contentAddressed = parsedDrv->contentAddressed(); | |||
|
|
|||
| if (this->contentAddressed) { | |||
src/libstore/build.cc
Outdated
| @@ -809,6 +809,9 @@ class DerivationGoal : public Goal | |||
| /* Whether this is a fixed-output derivation. */ | |||
| bool fixedOutput; | |||
|
|
|||
| /* Whether this is a content adressed derivation */ | |||
| bool contentAddressed = false; | |||
There was a problem hiding this comment.
Maybe not add this and use a temporary below in hopes that #3418 is merged soon?
There was a problem hiding this comment.
Mh right. I've removed it in favor of directly calling parsedDrv->contentAddressed()
|
BTW shouldn't |
You're definitely right. I didn't know about |
Not implementing anything here, just throwing an error if a derivation sets
__contentAddressed = truewithout--experimental-features content-addressed-paths(and also with it as there's nothing implemented yet)