Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-redis-exporter: init at 1.7.0 #90662

Merged
merged 4 commits into from Jun 18, 2020
Merged

prometheus-redis-exporter: init at 1.7.0 #90662

merged 4 commits into from Jun 18, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jun 17, 2020 •
edited

Motivation for this change

I needed this for production.

Things done

vgo2nix'ed deps pending discussions of #84826 to converge on some recommendation, I suppose.

Left out a few of the possible "version" parameters as "unknown" since I feel they're likely to get out of date during updates, and don't provide much additional value (save perhaps for sha1, reviewer might disagree with me there.)

Tested against local and remote redis servers. Stats are served and look correct.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb mentioned this pull request Jun 17, 2020
Closed
10 tasks
@srhb
Copy link
Contributor Author

srhb commented Jun 17, 2020

@eskytthe Added you as a maintainer here as requested. :)

Ma27
Ma27 reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a module for the prometheus-exporter (and probably a test as well)?

@Ma27 Ma27 requested a review from WilliButz June 17, 2020 16:08
@srhb
Copy link
Contributor Author

srhb commented Jun 17, 2020

Oh, yes, of course. Totally forgot about that. :) On it.

@srhb
Copy link
Contributor Author

srhb commented Jun 18, 2020

Done. The module is very minimal as the exporter is entirely configurable through command line flags . What a nice framework for creating and testing exporters. :)

WilliButz
WilliButz requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor thing:

pkgs/servers/monitoring/prometheus/redis-exporter.nix Outdated Show resolved Hide resolved
WilliButz
WilliButz approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus-exporters.redis

@WilliButz WilliButz merged commit 57a3249 into NixOS:master Jun 18, 2020
@srhb srhb deleted the redis-exporter branch June 18, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @WilliButz @Ma27 @eskytthe